Possible Bugs in Radiation OBC in t3dbc_im.F

Bug reports, work arounds and fixes

Moderators: arango, robertson

Post Reply
Message
Author
Barbara
Posts: 25
Joined: Thu Sep 14, 2006 4:33 pm
Location: LTO, SCSIO

Possible Bugs in Radiation OBC in t3dbc_im.F

#1 Post by Barbara » Mon Sep 30, 2013 3:03 am

The calcuation of tau in t3dbc_im.F of the latest version is writen as:

Code: Select all

                  tau=Tobc_out(itrc,ng,iwest)
                  IF ((dTdt*dTdx).lt.0.0_r8) THEN
                    tau=Tobc_in(itrc,ng,iwest)
                  ELSE
                    tau=tau*dt(ng)
                  END IF
and it should be:

Code: Select all

                  IF ((dTdt*dTdx).lt.0.0_r8) THEN
                    tau=Tobc_in(ng,iwest)
                  ELSE
                    tau=Tobc_out(ng,iwest)
                  END IF
                  tau=tau*dt(ng)

User avatar
arango
Site Admin
Posts: 1085
Joined: Wed Feb 26, 2003 4:41 pm
Location: IMCS, Rutgers University
Contact:

Re: Possible Bugs in Radiation OBC in t3dbc_im.F

#2 Post by arango » Tue Oct 01, 2013 1:43 am

Wow, great catch :!: You should get the award for the most significant bug discovered by a regular ROMS user. I updated the code. See the following :arrow: trac ticket for details.

Thank you for reporting this important bug. It is possible that it has very little impact in some applications. It just implies that boundary tracer value was not nudged as strongly as we specified.

User avatar
patrickm
Posts: 24
Joined: Fri Apr 30, 2004 6:41 pm
Location: IRD, FRANCE
Contact:

Re: Possible Bugs in Radiation OBC in t3dbc_im.F

#3 Post by patrickm » Tue Oct 01, 2013 7:13 am

Hi Hernan, could that explain the "inconsistency" between surface bulk formulations and OBCs in the simulations that you presented in Rio last year?

Post Reply