Ocean Modeling Discussion

ROMS/TOMS

Search for:
It is currently Fri Jul 19, 2019 2:24 pm




Post new topic Reply to topic  [ 1 post ] 

All times are UTC

Author Message
PostPosted: Wed Mar 10, 2010 9:13 am 
Offline

Joined: Fri Jan 26, 2007 7:27 pm
Posts: 7
Location: Università Politecnica delle Marche, ITALY
Hi all,

I'd like to report two minor bugs in latest revision (452), related to the passive tracer solution (flags T_PASSIVE and ANA_PSOURCE being affected):

1) in Utility/inp_par.F: line 1660:

When reading LtracerSrc from the input parameters, it assigns the value to LtracerSrc internal variable for Passive Tracers, here:
Code:
  1657              DO ng=1,Ngrids
  1658                DO itrc=1,NPT
  1659                  i=inert(itrc)
  1660                  LtracerSrc(i,ng)=Ltracer(itrc,ng)
  1661                END DO
  1662              END DO

since values for Active Tracers are assigned previously, the index for Ltracer in the right-hand side of the assignment should start from 3, not 1 (otherwise the logical values for temp and salt are applied again to the first two passive tracers). I'd change the line, as:
Code:
  1660                  LtracerSrc(i,ng)=Ltracer(i,ng)


2) in Functionals/ana_psource.h: line 270:

Just a typo here, in the OMP directive (BARRIER with 3 R)
Code:
   270  !$OMP BARRRIER


Thank you,
Alex

Edit: Sorry for having posted this, here. Later I realized I could open a trac ticket in the SVN repository site.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 1 post ] 

All times are UTC


Who is online

Users browsing this forum: Bing [Bot] and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group