Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

General scientific issues regarding ROMS

Moderators: arango, robertson

Post Reply
Message
Author
d.kobashi
Posts: 60
Joined: Tue Sep 28, 2010 11:59 pm
Location: Texas A&M University

Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

#1 Post by d.kobashi » Thu May 22, 2014 4:47 am

Hi,

I understand that some of the cpp options have been migrated from cppdefs.h into ROMS parameter file, ocean.in (e.g. open boundaries, TS_PSOURCE to LtracerSrc. etc.).

When I checked a example of cppdefs.h and ocean.in, I saw some options seem to be on both cppdefs.h and ocean.in. I checked wikiROMS to double-check it.

WikiROMS Cppdefs
https://www.myroms.org/wiki/index.php/cppdefs.h
WikiROMS ocean.in
https://www.myroms.org/wiki/index.php/ocean.in

My question is the following option in ocean.in
LtracerCLM == F F ! temperature, salinity, inert

My understanding is that the above option is equivalent to TCLIMATOLOGY (correct me if I am wrong), yet there is cpp option of TCLIMATOLOGY (in step_data.F step3d_t.F etc.).

I compared ROMS results between revision 514 and revision 715 (a realistic case for NGoM). The configuration between the two versions are same (try to be identical). I just wanted to know if the both versions produce a similar (but not identical) result. When I changed LtracerCLM to T T (and also defined TCLIMATOLOGY in cppdefs.h), the model output showed high temperature coming from all open boundaries into the domain with a noticeable difference. When I changed it to F F, the model looks very similar (almost identical, which I expected). For this test, I used OFES 10yr climatology for both versions.

I am still looking into this matter, but did someone have a similar situation? or am I misunderstanding? Any comments would be appreciated.
I use Revision 715.

Thanks in advance.

DJ Kobashi

User avatar
kate
Posts: 3772
Joined: Wed Jul 02, 2003 5:29 pm
Location: IMS/UAF, USA

Re: Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

#2 Post by kate » Thu May 22, 2014 4:20 pm

Are you sure you upgraded your ROMS version successfully? If I do:

Code: Select all

grep TCLIMATOLOGY */*/*
I get a lot of:

Code: Select all

ROMS/External/bio_Fennel.in:!                   climatology.  The CPP option TCLIMATOLOGY is now obsolete
ROMS/External/da_ocean.tmp:!                variables climatology.  The CPP option TCLIMATOLOGY is now
and nothing else. You are correct that this switch has migrated from cppdefs.h to ocean_xx.in.

d.kobashi
Posts: 60
Joined: Tue Sep 28, 2010 11:59 pm
Location: Texas A&M University

Re: Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

#3 Post by d.kobashi » Thu May 22, 2014 5:26 pm

Thanks for your reply, Kate.

I attach output of my grep. There are lots of hits.
>> grep TCLIMATOLOGY */*


My version of ROMS is a recent one (ROMS 3.7 rev 715). I downloaded it a couple of months ago.
>> cat Version
ROMS/TOMS Framework: Feb 10, 2014
===================

Copyright (c) 2002-2014 The ROMS/TOMS Group
Licensed under a MIT/X style license
See License_ROMS.txt

svn: $HeadURL: https://www.myroms.org/svn/src/trunk/ROMS/Version $
svn: $LastChangedBy: arango $
svn: $LastChangedRevision: 715 $
svn: $LastChangedDate: 2014-02-10 19:28:23 -0700 (Mon, 10 Feb 2014) $

I think what I can do is to get the latest version via subversion, try to run it and see if I can reproduce the problem.

Thanks,

DJ
Attachments
grep_TCLIMATOLOGY.txt
grep output for keyword TCLIMATOLOGY
(31.23 KiB) Downloaded 45 times

User avatar
kate
Posts: 3772
Joined: Wed Jul 02, 2003 5:29 pm
Location: IMS/UAF, USA

Re: Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

#4 Post by kate » Thu May 22, 2014 6:31 pm

Perhaps this change is more recent than your code. If I do "git log" on one of the files in my grep output, I get:

Code: Select all

pacman4 203% git log User/External/sediment.in
commit 38730d9bd3de329421f181fcded618444d2f0ad6
Author: arango <arango@f091316a-d328-0410-a40a-876eff57d070>
Date:   Thu Mar 13 22:25:13 2014 +0000

    src:ticket:627
    
    git-svn-id: https://www.myroms.org/svn/src/trunk@719 f091316a-d328-0410-a40a
-876eff57d070
Note this is trunk@719 from March.

User avatar
wilkin
Posts: 520
Joined: Mon Apr 28, 2003 5:44 pm
Location: Rutgers University
Contact:

Re: Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

#5 Post by wilkin » Fri May 23, 2014 3:11 am

The CLIMATOLOGY cpp option was removed a couple of months ago. It is certainly absent from the latest revision (736). It has been superceded by options within ocean.in.

It is difficult for us to keep the ROMS wiki up-to-date until these configuration changes stabilize. It is much more effective for you to follow the change notes posted in the trac timeline.

Go to https://www.myroms.org/projects/src/timeline and login with your ROMS credentials.

In this case, if you search for "CLIMATOLOGY" in search box at the top right of the page you can look down the list and quickly see the third item:

#627: upgrade: VERY IMPORTANT, Please READ: Overhaul of sponges, climatology, and nudging"
which links to
https://www.myroms.org/projects/src/ticket/627

This item explains the reason for the change, the cpp options removed, the logical flags added, and the ramifications for netcdf inputs.
John Wilkin: DMCS Rutgers University
71 Dudley Rd, New Brunswick, NJ 08901-8521, USA. ph: 609-630-0559 jwilkin@rutgers.edu

d.kobashi
Posts: 60
Joined: Tue Sep 28, 2010 11:59 pm
Location: Texas A&M University

Re: Duplication of TCLIMATOLOGY in cppdefs.h and ocean.in ?

#6 Post by d.kobashi » Sat May 24, 2014 3:45 am

Thanks for your reply, John and Kate. I downloaded the code this February so I guess that was in the middle of transition .... I confirmed that the latest trunk (rev 736) does not have TCLIMATOLOGY in the code.

Also, thanks for the link, John. I actually have been looking all over for a list of ROMS past updates, which you just pointed out.

Cheers,

DJ

Post Reply